New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified args and attrs in classes #3404
Commits on Nov 28, 2022
Commits on Nov 30, 2022
Commits on Dec 1, 2022
Commits on Dec 2, 2022
-
-
-
-
-
-
MessageEntity
: unify args and attrsit was not done completely in #3314 (`user` attr needed addition)
-
-
CallbackQuery
: unify args and attrsnot sure this is correct in the attrs, but I'm not changing it: data (:obj:`str` | :obj:`object`) (it's only `str` in args)
-
ChatInviteLink
: unify args and attrs* not sure I had to add the note for `invite_link` to args, but it is there in Telegram API * Telegram API contains no explicit limit for `name` arg/attr
-
ChatLocation
: unify args and attrsmaybe "Can't be a live location" and limit constants are not needed in attrs, but it matches Telegram API
-
Commits on Dec 3, 2022
-
-
-
`file_size` in attrs had wrong type too
-
InlineKeyboardButton
: unify args and attrs, fix bold textI didn't include Tip and ..seealso from `callback_data` argument as I assume it is not put into attrs on purpose
Commits on Dec 5, 2022
-
minor(
InlineKeyboardButton
) add ref to classit's not really needed, but at least monospace font was in place, I think, so why not put a reference
-
minor(
MenuButtonWebApp
) add ref to classBot
from reading the docstr it isn't clear that it's a method of Bot
-
-
-
-
-
-
text_entities was not marked with 'Optional.' in attrs. Leaving the phrase that is not there in Telegram API: "This list is empty if the message does not contain text entities."
Commits on Dec 6, 2022
Commits on Dec 7, 2022
-
-
'Document': unify args and attrs
including fix of lacking "Optional" in `.file_name`
-
'Force Reply': unify args and attrs
I decided to include the explanation for `selective` as well, but removed the phrase "Use this parameter" as it makes no sense in attrs
-
'InputMedia': unify args and attrs
I decided to add substitution strings to `parse_mode` and `caption_entities`, but did not duplicate `media` arg in attrs
-
minor: remove trailing colon in
versionchanged
Sphinx adds a colon automatically
-
Commits on Dec 8, 2022
-
-
InputMedia...
: unify args and attrs + fixInputMediaAudio.duration
* not changing docstr of `media` attr * move `thumb` up in attrs where applicable and apply |thumbdocstringbase| substitution (only the base should suffice as no directions are needed on how to send the file) * add "optional" to `duration` arg and attr of InputMediaAudio
-
-
-
fix(
KeyboardButtonPollType
): addArgs:
sectionre-formulate attrs section without "is passed" phrases
-
I see no harm in adding links/examples for types
-
-
-
Voice
: unify args and attrs + fixduration
duration arg is not optional in `Voice`
-
-
-
-
InlineQueryResultCachedGif
: fix typo in args`caption` was doubled in `title` arg
Commits on Dec 9, 2022
-
-
-
InlineQueryResultVideo
: unify args and attrsin attrs, all "optional" marks were done as in args, fix that
-
-
-
-
-
I think the 2nd part of docstring for `start_parameter` can be useful to understand this attr, despite the phrase addressing the generation of the Invoice
-
-
-
-
-
-
Commits on Dec 14, 2022
Commits on Dec 16, 2022
Commits on Dec 18, 2022
Commits on Dec 21, 2022
Commits on Dec 23, 2022
-
ChatInviteLink
: remove explanatory phrase forinvite_link
argIt makes sense in attrs but not in args