Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make answer_web_app_query insert/replace default values #3364

Merged
merged 3 commits into from Nov 18, 2022
Merged

Make answer_web_app_query insert/replace default values #3364

merged 3 commits into from Nov 18, 2022

Conversation

Bibo-Joshi
Copy link
Member

closes #3358

harshil21
harshil21 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels so ancient already

github-actions[bot]
github-actions bot reviewed Nov 15, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

@Bibo-Joshi
Copy link
Member Author

I can't seem to get the CI running, it always fails in the coverage step. coverage seems to be okay though and I'm going to ignore the unrelated DS issue. Merging.

@Bibo-Joshi Bibo-Joshi merged commit 01167c8 into v13.x Nov 18, 2022
@Bibo-Joshi Bibo-Joshi deleted the fix-answer-waq-v13 branch November 18, 2022 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@harshil21 harshil21 harshil21 approved these changes

Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bibo-Joshi @harshil21