Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in Filters #3272

Closed
wants to merge 6 commits into from
Closed

Fix typos in Filters #3272

wants to merge 6 commits into from

Commits on Oct 1, 2022

  1. Update BaseFilter class docstring

    @rglsk
    rglsk committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    043af1c View commit details
    Browse the repository at this point in the history

  2. Fix typing in BaseFilter.check_update base method and ignore override 

    There was an issue that base method returned only bool but typing was
saying something else just to match pylint override error.
    @rglsk
    rglsk committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    99c41f5 View commit details
    Browse the repository at this point in the history

  3. Fix typos in docstring in filters

    @rglsk
    rglsk committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    6e08131 View commit details
    Browse the repository at this point in the history

  4. Update class and methods docstring in filters to match the same conve… 

    …ntion.

Most of the code bases there is convention to start docstring with a new
line.
    @rglsk
    rglsk committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    704b04f View commit details
    Browse the repository at this point in the history

  5. Add optional return for dict in check_update docstring

    @rglsk
    rglsk committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    97453a7 View commit details
    Browse the repository at this point in the history

  6. Update return value in check_update

    @rglsk
    rglsk committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    7358850 View commit details
    Browse the repository at this point in the history