Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V13 API 6.2 implementation #3203

Merged
merged 7 commits into from Sep 4, 2022
Merged

V13 API 6.2 implementation #3203

merged 7 commits into from Sep 4, 2022

Conversation

Poolitzer
Copy link
Member

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts **_kwargs
  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard coded number and strings
    • Add new message types to Message.effective_attachment
    • Added new handlers for new update types
      • Add the handlers to the warning loop in the ConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast PR!

  • test_official is complaining that StickerSet.contains_masks is still present. Can you check how we handled such cases in the past?
  • DeepSource is complaining about two places where we could use f-strings. Feel free to improve, or just add a # skipcq: …

telegram/bot.py Outdated Show resolved Hide resolved
telegram/bot.py Show resolved Hide resolved
telegram/bot.py Outdated Show resolved Hide resolved
telegram/chat.py Show resolved Hide resolved
telegram/files/sticker.py Outdated Show resolved Hide resolved
telegram/message.py Show resolved Hide resolved
telegram/message.py Outdated Show resolved Hide resolved
telegram/message.py Outdated Show resolved Hide resolved
telegram/message.py Outdated Show resolved Hide resolved
telegram/message.py Outdated Show resolved Hide resolved
@harshil21 harshil21 added this to the v13.14 milestone Aug 26, 2022
@harshil21 harshil21 added the API label Aug 26, 2022
@Bibo-Joshi
Copy link
Member

Thanks for the updates. I think I'm happy with the changes, then. I vote to ignore DS on this for the reasons mentioned in https://discuss.deepsource.io/t/improve-granular-setting-possibility-to-pin-a-deepsource-version/472.

@Bibo-Joshi Bibo-Joshi merged commit dca596d into v13.x Sep 4, 2022
@Bibo-Joshi Bibo-Joshi deleted the v13-api6.2 branch September 4, 2022 07:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants