New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Edit on github links for v13.x documentation #3164
Fixed Edit on github links for v13.x documentation #3164
Conversation
btw jinja2 gives ImportError when using
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Is your sphinx version the one specified in requirements-docs.txt? The error probably happens since the versions aren't exactly matching the ones we specified.
okay since I see you're on a venv you probably have the right versions I'd say to go ahead and add that in (Jinja2 < 3.1). Makes sense you're getting this since I see this in the sphinx source code. |
Of course, done. |
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@harshil21 Anything else needed to merge this PR? |
Thanks for the contribution! |
You're very welcome. |
Checklist for PRs
.. versionadded:: version
,.. versionchanged:: version
or.. deprecated:: version
to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst
(optional)__all__
s