Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty lists #3057

Merged
merged 3 commits into from
May 26, 2022
Merged

Empty lists #3057

merged 3 commits into from
May 26, 2022

Conversation

Bibo-Joshi
Copy link
Member

Addresses #2741 (comment) and the respective item of #2633.

I also made some smaller code changes, hence this is a standalone PR instead of being included in the doc fixes pr.
In addition to updating the docs of Message, I also made corresponding changes to Poll and Game. Note that there are also classes like InlineQueryResult* which have a caption_entities attribute. However, those classes are used as input for API methods and having those attributes always be list would make problems - we'd have to somehow decide when to pass an empty list to TG and when to skip the parameter. So I left them as is.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@Bibo-Joshi Bibo-Joshi added this to the v20.0 milestone May 20, 2022
@Bibo-Joshi Bibo-Joshi mentioned this pull request May 20, 2022
24 tasks
telegram/_games/game.py Outdated Show resolved Hide resolved
@Bibo-Joshi Bibo-Joshi merged commit a17a4c6 into master May 26, 2022
@Bibo-Joshi Bibo-Joshi deleted the empty-lists branch May 26, 2022 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2022
@harshil21 harshil21 modified the milestones: v20.0, v20.0a1 Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants