API 5.6

[harshil21]

Checklist for PRs

• Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
• Created new or adapted existing unit tests
• Added myself alphabetically to AUTHORS.rst (optional)
• Added new classes & modules to the docs

If the PR contains API changes (otherwise, you can delete this passage)

• New classes:

  • Added self._id_attrs and corresponding documentation
  • __init__ accepts **_kwargs

• Added new shortcuts:

  • In Chat & User for all methods that accept chat/user_id
  • In Message for all methods that accept chat_id and message_id
  • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
  • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id

• If relevant:

  • Added new constants at telegram.constants and shortcuts to them as class variables
  • Added new handlers for new update types
  • Added new filters for new message (sub)types
  • Added or updated documentation for the changed class(es) and/or method(s)
  • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
  • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

[Bibo-Joshi]

Thanks for the quick PR!

• which fixture did you fix ragarding message entities?
• I guess test_bot is yet to be adapted? :D

[harshil21]

Thanks for the quick PR!

Thanks for the quick review!

• which fixture did you fix ragarding message entities?

See tests/test_messageentity.py. There was a spelling error.

• I guess test_bot is yet to be adapted? :D

I'm not sure what more to change in it, i'll see

[Bibo-Joshi]

• which fixture did you fix ragarding message entities?

See tests/test_messageentity.py. There was a spelling error.

ah, you mean type -> type_? yeah, that's good

• I guess test_bot is yet to be adapted? :D

I'm not sure what more to change in it, i'll see

well, currently codecov complains about all the if protected_content: not being covered. While the coverage report will be more friendly when moving that clause into self._message (because then it's fewer of those), we should actually test it - should be doable by checking Message.has_protected_content on the return value in most cases.

[github-actions]

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

[Bibo-Joshi]

Nice! Apart from nitpicking, I guess it's ready, though I'd like for @Poolitzer to have a look as well.

just double checking: are you both comfortable with postponing Defaults.protect_content to v14? If you prefer to include it directly, we can do that.

[Poolitzer]

LGTM! Im comfortable with postponing Defaults, jup.

[ghost]

pain in the ass -_-

[Bibo-Joshi]

what?