Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in README #2756

Closed
wants to merge 1 commit into from
Closed

Conversation

seadog007
Copy link

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)

@Poolitzer
Copy link
Member

Set the logging level, sure. But I think "install from source" is the correct technically term. Why did you put a the there?

@seadog007
Copy link
Author

My bad, fixing that

@Bibo-Joshi
Copy link
Member

I'm pretty sure that setting is correct here. The sentence basically reads You can also use logs in your application by [...] stetting the log level you want: or You can also use logs in your application by calling ``logging.getLogger()`` and by setting the log level you want:

Copy link
Member

@Bibo-Joshi Yeah 'setting' sounds right

@Bibo-Joshi
Copy link
Member

I'll go ahead and close, then. Still, thank you @seadog007 for reaching out with improvement suggestions! I've you're interested in other doc improvements, you can have a look at #2633 :)

@Bibo-Joshi Bibo-Joshi closed this Oct 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants