Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation Improvements #2693

Merged
merged 54 commits into from
Dec 13, 2021
Merged

Documentation Improvements #2693

merged 54 commits into from
Dec 13, 2021

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Oct 3, 2021 •
edited

This PR gathers contributions regarding the documentation of python-telegram-bot, especially contributions for #2633.

  • When merging, we should make sure that the commit message includes the unmbers of all PRs that were merged into doc-fixes

@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Oct 3, 2021
github-actions[bot]
github-actions bot reviewed Oct 3, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@Bibo-Joshi Bibo-Joshi mentioned this pull request Oct 3, 2021
Closed
24 tasks
@hirdyansh05
Copy link

hey, there is a typo in #2693 (comment). You have documented the spell of numbers wrong.

Bibo-Joshi and others added 23 commits November 12, 2021 16:15
@Bibo-Joshi
Temporarily enable tests for the v14 branch
ae7bca7
@harshil21 @Bibo-Joshi
Move and Rename TelegramDecryptionError to telegram.error.PassportDec…
fd2745a 
…ryptionError (#2621)
@Poolitzer @Bibo-Joshi
Add Code Comment Guidelines to Contribution Guide (#2612)
3351d7f 
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@revolter @Bibo-Joshi
Improve Type Hinting for CallbackContext (#2587)
f5faacf 
Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
@Poolitzer @Bibo-Joshi
Add Custom pytest Marker to Ease Development (#2628)
d66eb7a 
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@starry-shivam @Bibo-Joshi
Make BasePersistence Methods Abstract (#2624)
9c9fbf3 
Signed-off-by: starry69 <starry369126@outlook.com>
Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
@Bibo-Joshi
Refactor Initialization of Persistence Classes (#2604)
d98c59d
@harshil21 @Bibo-Joshi
Remove __dict__ from __slots__ and drop Python 3.6 (#2619, #2636)
273223c
@iota-008 @Bibo-Joshi
Remove day_is_strict argument of JobQueue.run_monthly (#2634)
f624cde 
Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
@Poolitzer @Bibo-Joshi
Drop Non-CallbackContext API (#2617)
b4932eb
@harshil21 @Bibo-Joshi
Fix Signatures and Improve test_official (#2643)
c576630
@Bibo-Joshi
Remove Deprecated Functionality (#2644, #2740, #2745)
1814150
@harshil21 @Bibo-Joshi
Add User Friendly Type Check For Init Of {Inline, Reply}KeyboardMarkup (
c381aba 
#2657)
@Bibo-Joshi @harshil21
Refine Dispatcher.dispatch_error (#2660)
e953830 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@harshil21 @Bibo-Joshi
Warnings Overhaul (#2662)
cf14239
@Bibo-Joshi @harshil21
Clear Up Import Policy (#2671)
4b9c593 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Bibo-Joshi
Make InlineQuery.answer Raise ValueError (#2675)
420dd22
@Bibo-Joshi @harshil21 @Poolitzer
Doc Fixes (#2597)
bc69fd3 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: poolitzer <25934244+Poolitzer@users.noreply.github.com>
@Bibo-Joshi
Move Defaults to telegram.ext (#2648)
8bfc653
@Poolitzer @Bibo-Joshi
Update Notification Workflows (#2695)
203d337
@Bibo-Joshi
Pass Failing Jobs to Error Handlers (#2692)
d96fcb7
@harshil21 @Bibo-Joshi
Improve Signature Inspection for Bot Methods (#2686)
96a6d59
@eldbud @Bibo-Joshi
Handle Filepaths via the Pathlib Module (#2688)
cb04c4e
@Bibo-Joshi
Copy link
Member Author

I'll go ahead and merge the changes that already have. should save us some merging

@Bibo-Joshi Bibo-Joshi merged commit 5c26c91 into v14 Dec 13, 2021
@Bibo-Joshi Bibo-Joshi deleted the doc-fixes branch December 13, 2021 17:21
Bibo-Joshi added a commit that referenced this pull request Dec 13, 2021
@Bibo-Joshi
Documentation Improvements (#2693, #2691, #2739)
74c4270
Poolitzer pushed a commit that referenced this pull request Dec 17, 2021
@Bibo-Joshi @Poolitzer
Documentation Improvements (#2693, #2691, #2739)
e4b9a98
Poolitzer pushed a commit that referenced this pull request Dec 17, 2021
@Bibo-Joshi @Poolitzer
Documentation Improvements (#2693, #2691, #2739)
be40a83
Poolitzer pushed a commit that referenced this pull request Dec 18, 2021
@Bibo-Joshi @Poolitzer
Documentation Improvements (#2693, #2691, #2739)
65f3599
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.

None yet