-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 5.3 #2572
API 5.3 #2572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scopes look good - one tiny doc fix.
Signed-off-by: starry69 <starry369126@outlook.com>
and add `delete_my_commands()`
…y.py also improved/fixed docs along the way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)
# Conflicts: # tests/test_bot.py
Signed-off-by: starry69 <starry369126@outlook.com>
Signed-off-by: starry69 <starry369126@outlook.com>
Signed-off-by: starry69 <starry369126@outlook.com>
Note about slots: I had remove the test lines that @harshil21 pointed out, b/c we are adding new classes and I thought that we don't need to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)
Signed-off-by: starry69 <starry369126@outlook.com>
Signed-off-by: starry69 <starry369126@outlook.com>
BotCommandScope*
is just for input, never output (at least for now), so we don't really need a properde_json
. But I realized that only after I had implemented it … If you think it's superfluous, we can removeChecklist for PRs
.. versionadded:: version
,.. versionchanged:: version
or.. deprecated:: version
to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst
(optional)If the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrs
and corresponding documentation__init__
accepts**_kwargs
Added new shortcuts:
Chat
&User
for all methods that acceptchat/user_id
-> We need to deprecateChat.get_members_count
in favor of a newChat.get_member_count
and the same forkick_chat_member
->ban_chat_member
[ ] InMessage
for all methods that acceptchat_id
andmessage_id
[ ] For newMessage
shortcuts: Addedquote
argument if methods acceptsreply_to_message_id
[ ] InCallbackQuery
for all methods that accept eitherchat_id
andmessage_id
orinline_message_id
If relevant:
telegram.constants
and shortcuts to them as class variables[ ] Added new handlers for new update types[ ] Added new filters for new message (sub)typesREADME.rst
andREADME_RAW.rst
(including the badge), as well astelegram.constants.BOT_API_VERSION
[ ] Added logic for arbitrary callback data intg.ext.Bot
for new methods that either accept areply_markup
in some form or have a return type that is/containstelegram.Message