Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw warning when passing defaults to ExtBot #2553

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi added this to the v14 milestone Jun 7, 2021
@Bibo-Joshi Bibo-Joshi requested a review from Poolitzer June 7, 2021 17:37
@Poolitzer
Copy link
Member

Two things I don't understand.

I hope I understand this correctly though: We don't want to put the defaults logic into ExtBot yet because that would be breaking, but we intend to do this in the future.

If we don't want to remove the logic from Bot just yet, why are you still passing it in init? You could just set it manually after creating the Bot instance. This way you catch people doing it in their Bot() init, while still be able to do it yourself. I mean your solution works, but it just seems a tad complicated.

Secondly, I would actually release a fix release for this. Maybe wait a week (or some more) to see if more bugs show themselves, but this is a warning which shows up when you do everything correctly. I know its just a warning, but people tend to treat warnings as errors (which I personally support), and I bet we will get a lot of people asking the same question as soon as they update, which we can avoid and should imo.

@Bibo-Joshi Bibo-Joshi requested review from Poolitzer and removed request for Poolitzer June 9, 2021 15:06
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Poolitzer Poolitzer modified the milestones: v14, v13.6.1 Jun 10, 2021
@Bibo-Joshi Bibo-Joshi merged commit ac47681 into master Jun 10, 2021
@Bibo-Joshi Bibo-Joshi deleted the defaults-deprecation-warning branch June 10, 2021 10:03
sakibguy added a commit to sakibguy/python-telegram-bot that referenced this pull request Jun 11, 2021
Remove Incorrect Warning About Defaults and ExtBot (python-telegram-bot#2553)
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants