Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix posonlyargs and kwonlyargs when extracting method #597

Merged
merged 7 commits into from Dec 14, 2022
Merged

Fix posonlyargs and kwonlyargs when extracting method #597

merged 7 commits into from Dec 14, 2022

Commits on Dec 14, 2022

  1. Fix #566. Add kwonlyargs to list of written arguments when extracting

    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    5fb5359 View commit details
    Browse the repository at this point in the history

  2. Fix #567. Add posonlyargs to list of written arguments when extracting

    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    fcbd54c View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md

    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    f1393db View commit details
    Browse the repository at this point in the history

  4. Simplify _get_argnames() 

    There's no need to check for emptiness; if they're empty, the list
comprehension already is no-op anyway.
    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    5f24a11 View commit details
    Browse the repository at this point in the history

  5. Fix Python 3.7 doesn't have posonlyargs

    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    5819fd2 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary if isinstance(node, ast.arg) check 

    This was a holdover from Python 2, where `arguments` could be a list of
`ast.Name` node instead of `ast.arg` nodes.
    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    d3bfca1 View commit details
    Browse the repository at this point in the history

  7. Mark test_extract_function_with_posonlyargs() for Python 3.8 and higher 

    This is new syntax from Python 3.8.
    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    c1b809c View commit details
    Browse the repository at this point in the history