Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #589 Cleanup testutils.sample_project() #596

Merged
merged 7 commits into from Dec 14, 2022
Merged

Fix #589 Cleanup testutils.sample_project() #596

merged 7 commits into from Dec 14, 2022

Commits on Dec 14, 2022

  1. Remove redundant testutils.sample_project(ropefolder) arguments 

    These were specifying default .ropeproject folder anyway, so it
functionally doesn't make a difference.
    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    3fc0b8d View commit details
    Browse the repository at this point in the history

  2. Simplify implementation of sample_project() 

    Also, should fix issue #589
    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    0056b3e View commit details
    Browse the repository at this point in the history

  3. Remove root argument 

    This is barely used anywhere and the only place where it does, we can
use foldername instead.
    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    f7e1d27 View commit details
    Browse the repository at this point in the history

  4. Change testutils.py to use pathlib

    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    408e025 View commit details
    Browse the repository at this point in the history

  5. Rewrite test that creates errant sample_folder directory

    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    083ce67 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary remove_recursively() when creatings sample_project() 

    Now that we always create new temp directory, there is no need to
pre-emptively try to clean the directory from previous runs.
    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    ad71deb View commit details
    Browse the repository at this point in the history

  7. Update CHANGELOG.md

    @lieryan
    lieryan committed Dec 14, 2022
    Copy the full SHA
    a046db6 View commit details
    Browse the repository at this point in the history