Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove functions in rope.base.ast that has functionally identical implementation in stdlib's ast #581

Merged
merged 8 commits into from Dec 9, 2022
Merged

Remove functions in rope.base.ast that has functionally identical implementation in stdlib's ast #581

merged 8 commits into from Dec 9, 2022

Commits on Dec 9, 2022

  1. Rename rope.base.ast.{walk->walk_visitor} 

    This is a name clash with standard library's `ast.walk()`, which has a
different, and incompatible interface.
    @lieryan
    lieryan committed Dec 9, 2022
    Copy the full SHA
    f4c4ff4 View commit details
    Browse the repository at this point in the history

  2. Clarify the documentation on walker->visitor

    @lieryan
    lieryan committed Dec 9, 2022
    Copy the full SHA
    e507c8f View commit details
    Browse the repository at this point in the history

  3. Simplify implementation of ast.get_children() and ast.get_child_nodes() 

    These functions are no longer be necessary in supported versions of
Python, as a version with equivalent functionalities are now included in
stdlib `ast`.
    @lieryan
    lieryan committed Dec 9, 2022
    Copy the full SHA
    a9815b1 View commit details
    Browse the repository at this point in the history

  4. Remove usages of get_child_nodes() 

    This has been replaced with iter_child_nodes()

Note that iter_child_nodes() returns an iterator while get_child_nodes()
returns a List.
    @lieryan
    lieryan committed Dec 9, 2022
    Copy the full SHA
    d6baf62 View commit details
    Browse the repository at this point in the history

  5. Remove usages of get_children() 

    This is now replaced with ast.iter_fields()

Note that iter_fields() returns an iterator while get_children()
returns a List.
    @lieryan
    lieryan committed Dec 9, 2022
    Copy the full SHA
    d754e53 View commit details
    Browse the repository at this point in the history

  6. Remove rope.base.ast.walk() 

    This is functionally identical to stdlib's ast.NodeVisitor
    @lieryan
    lieryan committed Dec 9, 2022
    Copy the full SHA
    ab5562b View commit details
    Browse the repository at this point in the history

  7. Black

    @lieryan
    lieryan committed Dec 9, 2022
    Copy the full SHA
    6dfa164 View commit details
    Browse the repository at this point in the history

  8. Update CHANGELOG.md

    @lieryan
    lieryan committed Dec 9, 2022
    Copy the full SHA
    722eaea View commit details
    Browse the repository at this point in the history