Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: walk does not return a value #578

Merged
merged 6 commits into from Dec 6, 2022
Merged

PR: walk does not return a value #578

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b37361
Blacken one file
edreamleo Nov 30, 2022
d8b4796
Merge branch 'master' of https://github.com/python-rope/rope
edreamleo Dec 1, 2022
e463b12
Fix weird reversion. All tests now pass
edreamleo Dec 1, 2022
107e937
Merge branch 'master' of https://github.com/python-rope/rope
edreamleo Dec 3, 2022
d769b61
Merge branch 'master' of https://github.com/python-rope/rope
edreamleo Dec 6, 2022
a265149
Second try: walk should not ever return a value
edreamleo Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions rope/base/ast.py
View file
Open in desktop
Expand Up @@ -22,12 +22,13 @@ def parse(source, filename="<string>"):
raise error


def walk(node, walker):
def walk(node, walker) -> None:
"""Walk the syntax tree"""
method_name = "_" + node.__class__.__name__
method = getattr(walker, method_name, None)
if method is not None:
return method(node)
method(node)
return
for child in get_child_nodes(node):
walk(child, walker)

Expand Down