Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for #551: fix minor flake8 complaints #552

Merged
merged 23 commits into from Dec 3, 2022
Merged

PR for #551: fix minor flake8 complaints #552

merged 23 commits into from Dec 3, 2022

Commits on Nov 28, 2022

  1. Fix the first (simplest) batch of minor flake8 complaints

    @edreamleo
    edreamleo committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    20f10bb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ekr-flake8

    @edreamleo
    edreamleo committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ac6bce0 View commit details
    Browse the repository at this point in the history

  3. Fix a potential crasher apparently not caught by a unit test

    @edreamleo
    edreamleo committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    bd36aef View commit details
    Browse the repository at this point in the history

  4. Removed an unnecessary '# noqa'

    @edreamleo
    edreamleo committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6d35a19 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into ekr-flake8

    @edreamleo
    edreamleo committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    95ea866 View commit details
    Browse the repository at this point in the history

  6. Add .pylintrc. Suppress pylint complaint in project.py

    @edreamleo
    edreamleo committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    db75d42 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Improve opening comments

    @edreamleo
    edreamleo committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    b0e3ef0 View commit details
    Browse the repository at this point in the history

  2. Still better opening comments

    @edreamleo
    edreamleo committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    7298879 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ekr-flake8

    @edreamleo
    edreamleo committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    af2a2ff View commit details
    Browse the repository at this point in the history

  4. Fix B007: Loop control variable 'whatever' not used within the loop body

    @edreamleo
    edreamleo committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    8468270 View commit details
    Browse the repository at this point in the history

  5. Fix B009: Do not call getattr with a constant attribute value, it is … 

    …not any safer than normal property access.
    @edreamleo
    edreamleo committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    975c2f4 View commit details
    Browse the repository at this point in the history

  6. Fix B011

    @edreamleo
    edreamleo committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    86503e4 View commit details
    Browse the repository at this point in the history

  7. blacken

    @edreamleo
    edreamleo committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    23188bc View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Merge branch 'master' into ekr-flake8

    @edreamleo
    edreamleo committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    12c781a View commit details
    Browse the repository at this point in the history

  2. Add suppressions to suppress all flake8 messages

    @edreamleo
    edreamleo committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    d1b078b View commit details
    Browse the repository at this point in the history

  3. Change _MoveTools.occurs_in_module per lieryan's suggestion. All test… 

    …s pass
    @edreamleo
    edreamleo committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    4739b79 View commit details
    Browse the repository at this point in the history

  4. Use lieryan's second suggestion

    @edreamleo
    edreamleo committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    ad9c23e View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Restore setup.cfg from master

    @edreamleo
    edreamleo committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    e560a08 View commit details
    Browse the repository at this point in the history

  2. Fix 'ambiguous name' complaint

    @edreamleo
    edreamleo committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    c364775 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ekr-flake8

    @edreamleo
    edreamleo committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    12e52e0 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Restore assert statements, using an f-string for one of them

    @edreamleo
    edreamleo committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    20b331e View commit details
    Browse the repository at this point in the history

  2. Suppress flake8 B007 test and remove recently added underscores for l… 

    …oop vars
    @edreamleo
    edreamleo committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b0f2062 View commit details
    Browse the repository at this point in the history

  3. Suppress flake8 B011 warning

    @edreamleo
    edreamleo committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    ddbb957 View commit details
    Browse the repository at this point in the history