Fix pylint and mypy complaints re the walk function in rope.base.ast #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 70a592c.
edreamleo
changed the title
|
Closed because of unwanted commits. See PR #536 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] Add *.leo to .gitignore so that ongoing changes to .leo files don't pollute rope's code base.
[x] The walk function should not appear to return a value.
[x] Add
-> Nonefor mypy.[x] All unit tests pass.
@lieryan Hmm. The diffs for this PR are correct, but there should have been only two commits. Perhaps I should have done a clean or rebase? Any help cleaning this PR would be appreciated.