Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of unicode type #533

Merged
merged 6 commits into from Nov 25, 2022
Merged

Remove usage of unicode type #533

merged 6 commits into from Nov 25, 2022

Commits on Nov 25, 2022

  1. Annotate return value of unicode_to_file_data()

    @lieryan
    lieryan committed Nov 25, 2022
    Copy the full SHA
    3df3206 View commit details
    Browse the repository at this point in the history

  2. Change unicode_to_file_data() to now only take str 

    Simplify handling of str/unicode distinction that had been a relic of
Python 2 transition.
    @lieryan
    lieryan committed Nov 25, 2022
    Copy the full SHA
    10b42eb View commit details
    Browse the repository at this point in the history

  3. Remove unicode->str type aliasing 

    unicode was a relic of Python 2 transition. rope no longer support
Python 2, so this is no longer needed.
    @lieryan
    lieryan committed Nov 25, 2022
    Copy the full SHA
    f2063ff View commit details
    Browse the repository at this point in the history

  4. Remove redundant call to _decode_data() 

    In Python 3, ast always returns `str` here, and `_decode_data()` is
basically no-op.
    @lieryan
    lieryan committed Nov 25, 2022
    Copy the full SHA
    65ab0de View commit details
    Browse the repository at this point in the history

  5. Use older Union syntax, we can't use the | syntax yet

    @lieryan
    lieryan committed Nov 25, 2022
    Copy the full SHA
    2fe98b0 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into unicode-handling

    @lieryan
    lieryan committed Nov 25, 2022
    Copy the full SHA
    e71c145 View commit details
    Browse the repository at this point in the history