Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pytest.ini to pyproject.toml #450

Closed
wants to merge 1 commit into from
Closed

Migrate pytest.ini to pyproject.toml #450

wants to merge 1 commit into from

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Nov 26, 2021

Signed-off-by: Gábor Lipták gliptak@gmail.com

Description

Please include a summary of the change and which issue is fixed.

Fixes #414

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md
  • I have made corresponding changes to user documentation for new features
  • I have made corresponding changes to library documentation for API changes

Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@lieryan
Copy link
Member

lieryan commented Nov 28, 2021

Hi @gliptak, thanks for making this PR. The latest version of pytest that supports Python 2.7 unfortunately doesn't support putting configuration in pyproject.toml; so unfortunately, we'll have to keep the settings in pytest.ini until we drop Python 2.7 support officially.

@gliptak
Copy link
Contributor Author

gliptak commented Nov 28, 2021

@lieryan would you be interested in that PR to drop already EOL 2.7 and 3.5 including soon to be EOL 3.6?

https://www.python.org/downloads/

@gliptak gliptak closed this Nov 28, 2021
@gliptak gliptak reopened this Nov 28, 2021
@lieryan
Copy link
Member

lieryan commented Nov 29, 2021

We want to drop 2.7 eventually, we have a rudimentary deprecation plan for Python 2.7 in #400. But for the moment we still maintain support for it. So let's keep this PR open until that moment comes

@lieryan lieryan mentioned this pull request Nov 29, 2021
7 tasks
@lieryan lieryan added this to the 1.5.0 milestone Oct 24, 2022
@bagel897
Copy link
Contributor

bagel897 commented Nov 4, 2022

Maybe update this to get the latest CI?

@gliptak
Copy link
Contributor Author

gliptak commented Nov 4, 2022

@bagel897 consider repushing as repo local branch

@bagel897
Copy link
Contributor

bagel897 commented Nov 4, 2022

I mean update this branch to the latest CI which is 3.7-3.11, just merge master. If not, I can make a new PR with the same stuff.

@gliptak
Copy link
Contributor Author

gliptak commented Nov 4, 2022

@bagel897 please make a new branch

@bagel897
Copy link
Contributor

bagel897 commented Nov 4, 2022

Moved to #519

@gliptak gliptak closed this Nov 4, 2022
@lieryan
Copy link
Member

lieryan commented Nov 5, 2022

Thanks for creating this PR @gliptak, thanks @bagel897 for updating this PR forwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate pytest.ini to pyproject.toml
3 participants