Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inlining into f-string containing quote characters #420

Merged
merged 6 commits into from Sep 27, 2021
Merged

Fix inlining into f-string containing quote characters #420

merged 6 commits into from Sep 27, 2021

Commits on Sep 27, 2021

  1. Allow retrieving prefix as match group in get_string_pattern_with_pre… 

    …fix()
    @lieryan
    lieryan committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    8150711 View commit details
    Browse the repository at this point in the history

  2. Improve simplification of f-string 

    Previously, if there are quotes inside f-string like so:

    s = f' test "{hello}" test'

the simplifier will match and simplify "{hello}", producing the
following simplified text:

    s = f' test "       " test'

This change fixes that and prevents simplification in f-strings, as they
may contain symbols that we need to scan for during inlining.
    @lieryan
    lieryan committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    56b2312 View commit details
    Browse the repository at this point in the history

  3. Black formatting

    @lieryan
    lieryan committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    8b18cc1 View commit details
    Browse the repository at this point in the history

  4. Set minimum Python version for test

    @lieryan
    lieryan committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    cbdd139 View commit details
    Browse the repository at this point in the history

  5. Add contributors

    @lieryan
    lieryan committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    1624d2b View commit details
    Browse the repository at this point in the history

  6. Update CHANGELOG.md

    @lieryan
    lieryan committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    823ec40 View commit details
    Browse the repository at this point in the history