Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_generate with goal_resource param #332

Merged
merged 1 commit into from Mar 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions rope/contrib/generate.py
Expand Up @@ -5,15 +5,15 @@
from rope.refactor import sourceutils, importutils, functionutils, suites


def create_generate(kind, project, resource, offset):
def create_generate(kind, project, resource, offset, goal_resource=None):
"""A factory for creating `Generate` objects

`kind` can be 'variable', 'function', 'class', 'module' or
'package'.

"""
generate = eval('Generate' + kind.title())
return generate(project, resource, offset)
return generate(project, resource, offset, goal_resource=goal_resource)


def create_module(project, name, sourcefolder=None):
Expand Down
26 changes: 26 additions & 0 deletions ropetest/contrib/generatetest.py
Expand Up @@ -284,6 +284,32 @@ def test_generating_function_in_a_suite_in_a_function(self):
' if 1:\n g()\n',
self.mod.read())

def test_create_generate_class_with_goal_resource(self):
code = 'c = C()\n'
self.mod.write(code)

result = generate.create_generate(
"class",
self.project,
self.mod,
code.index("C"),
goal_resource=self.mod2)

self.assertTrue(isinstance(result, generate.GenerateClass))
self.assertEqual(result.goal_resource, self.mod2)

def test_create_generate_class_without_goal_resource(self):
code = 'c = C()\n'
self.mod.write(code)

result = generate.create_generate(
"class",
self.project,
self.mod,
code.index("C"))

self.assertTrue(isinstance(result, generate.GenerateClass))
self.assertIsNone(result.goal_resource)

if __name__ == '__main__':
unittest.main()