Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix posonlyargs and kwonlyargs when extracting method #597

Merged
merged 7 commits into from Dec 14, 2022
Merged

Fix posonlyargs and kwonlyargs when extracting method #597

merged 7 commits into from Dec 14, 2022

Conversation

lieryan
Copy link
Member

@lieryan lieryan commented Dec 14, 2022

Description

Fixes #566, #567

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md

@lieryan lieryan self-assigned this Dec 14, 2022
@lieryan
Simplify _get_argnames()
5f24a11 
There's no need to check for emptiness; if they're empty, the list
comprehension already is no-op anyway.
@lieryan
Fix Python 3.7 doesn't have posonlyargs
5819fd2
@lieryan
Remove unnecessary if isinstance(node, ast.arg) check
d3bfca1 
This was a holdover from Python 2, where `arguments` could be a list of
`ast.Name` node instead of `ast.arg` nodes.
@lieryan
Mark test_extract_function_with_posonlyargs() for Python 3.8 and higher
c1b809c 
This is new syntax from Python 3.8.
@lieryan lieryan merged commit 7fc05ef into master Dec 14, 2022
@lieryan lieryan deleted the lieryan-posonlyargs-kwonlyargs-scope branch December 14, 2022 05:57
@lieryan lieryan added this to the 1.6.0 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lieryan lieryan

Labels
enhancement extract-refactor
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Extract method doesn't pass keyword-only arguments to the new method
1 participant
@lieryan