Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #589 Cleanup testutils.sample_project() #596

Merged
merged 7 commits into from Dec 14, 2022
Merged

Fix #589 Cleanup testutils.sample_project() #596

merged 7 commits into from Dec 14, 2022

Conversation

lieryan
Copy link
Member

@lieryan lieryan commented Dec 14, 2022 •
edited

  • Remove redundant testutils.sample_project(ropefolder) arguments
  • Simplify implementation of sample_project()
  • Remove root argument
  • Change testutils.py to use pathlib
  • Rewrite test that creates errant sample_folder directory
  • Remove unnecessary remove_recursively() when creatings sample_project()

Fixes #589

@lieryan
Remove redundant testutils.sample_project(ropefolder) arguments
3fc0b8d 
These were specifying default .ropeproject folder anyway, so it
functionally doesn't make a difference.
@lieryan
Simplify implementation of sample_project()
0056b3e 
Also, should fix issue #589
@lieryan
Remove root argument
f7e1d27 
This is barely used anywhere and the only place where it does, we can
use foldername instead.
@lieryan
Change testutils.py to use pathlib
408e025
@lieryan
Rewrite test that creates errant sample_folder directory
083ce67
@lieryan
Remove unnecessary remove_recursively() when creatings sample_project()
ad71deb 
Now that we always create new temp directory, there is no need to
pre-emptively try to clean the directory from previous runs.
@lieryan lieryan self-assigned this Dec 14, 2022
@lieryan lieryan merged commit eeacfed into master Dec 14, 2022
@lieryan lieryan deleted the lieryan-589-testutils branch December 14, 2022 04:40
@lieryan lieryan mentioned this pull request Dec 14, 2022
Closed
@lieryan lieryan added this to the 1.6.0 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lieryan lieryan

Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Killed unit tests can leave a sample_project folder in the top-level folder
1 participant
@lieryan