Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: remove rope.base.utils.pycompat #549

Merged
merged 4 commits into from Nov 28, 2022
Merged

PR: remove rope.base.utils.pycompat #549

merged 4 commits into from Nov 28, 2022

Conversation

edreamleo
Copy link
Contributor

@edreamleo edreamleo commented Nov 28, 2022

This PR contains the minimum changes required to delete pycompat.py.

  • Remove all references to rope.base.utils.pycompat.
  • Dubious? Always define basestring as (str, bytes) in rope/refactor/patchedast.py.
  • Remove rope/base/utils/pycompat.py
  • All unit tests pass.
  • reindent and blacken all files.

@edreamleo
Copy link
Contributor Author

edreamleo commented Nov 28, 2022

@lieryan I'm not sure where (against what branch) or when you might like this PR merged.

What would you like to do?

rope/base/prefs.py Outdated Show resolved Hide resolved
Black misses this since this file is excluded from it
@lieryan
Copy link
Member

lieryan commented Nov 28, 2022

main is good for the target for most PRs

Thanks for cleaning this file up, @edreamleo.

@all-contributors add @edreamleo for code

@allcontributors
Copy link
Contributor

@lieryan

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @edreamleo! 🎉

@lieryan lieryan merged commit 43f8e7c into python-rope:master Nov 28, 2022
@lieryan lieryan added this to the 1.6.0 milestone Nov 28, 2022
@edreamleo edreamleo deleted the ekr-clean-imports branch November 28, 2022 15:16
@edreamleo
Copy link
Contributor Author

@lieryan I've never heard of contributions or contribution names, so I have no idea what the bot is talking about :-)

Do you have any idea what I should do?

@lieryan
Copy link
Member

lieryan commented Nov 28, 2022

Nothing to do. I'm not sure what the bot is even complaining about, since the it created its PR correctly. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants