Skip to content

Fix potential crasher in merged PR #549 #553

Closed
@edreamleo

Description

@edreamleo
Contributor

Somehow unit tests failed to discover a potential crasher in PR #549. This PR has been merged into master.

Happily, flake8 did highlight the problem. It's in the _getarguments function in rope.refactor.extract.

Rev bd36aef in the ekr-flake8 branch fixes the problem. I'll create a new PR asap for just this one fix.

Activity

added
bugUnexpected or incorrect user-visible behavior
on Nov 28, 2022
added a commit that references this issue on Nov 28, 2022

Merge pull request #554 from edreamleo/ekr-getarguments

61c2b05
added this to the 1.6.0 milestone on Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugUnexpected or incorrect user-visible behavior

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @edreamleo@lieryan

        Issue actions

          Fix potential crasher in merged PR #549 · Issue #553 · python-rope/rope