Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential crasher in merged PR #549 #553

Closed
edreamleo opened this issue Nov 28, 2022 · 0 comments
Closed

Fix potential crasher in merged PR #549 #553

edreamleo opened this issue Nov 28, 2022 · 0 comments
Labels
bug Unexpected or incorrect user-visible behavior
Milestone
1.6.0

Comments

@edreamleo
Copy link
Contributor

edreamleo commented Nov 28, 2022 •
edited

Somehow unit tests failed to discover a potential crasher in PR #549. This PR has been merged into master.

Happily, flake8 did highlight the problem. It's in the _getarguments function in rope.refactor.extract.

Rev bd36aef in the ekr-flake8 branch fixes the problem. I'll create a new PR asap for just this one fix.
@edreamleo edreamleo added the bug Unexpected or incorrect user-visible behavior label Nov 28, 2022
@edreamleo edreamleo mentioned this issue Nov 28, 2022
Merged
lieryan added a commit that referenced this issue Nov 28, 2022
@lieryan
Merge pull request #554 from edreamleo/ekr-getarguments
61c2b05 
PR for #553: Fix potential crasher in _getarguments
@lieryan lieryan closed this as completed Nov 28, 2022
@lieryan lieryan added this to the 1.6.0 milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected or incorrect user-visible behavior
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@edreamleo @lieryan