Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean the walk function in rope.base.ast #536

Merged
merged 2 commits into from Nov 27, 2022
Merged

Clean the walk function in rope.base.ast #536

merged 2 commits into from Nov 27, 2022

Conversation

edreamleo
Copy link
Contributor

@edreamleo edreamleo commented Nov 26, 2022

The walk function should not appear to return a value.

The legacy code generates (valid) errors from pylint and mypy.

  • All unit tests pass.

@lieryan lieryan merged commit 48ad2f8 into python-rope:master Nov 27, 2022
@lieryan lieryan added this to the 1.6.0 milestone Nov 28, 2022
@edreamleo edreamleo deleted the ekr-walk3 branch December 6, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants