Fix #566. Add kwonlyargs to list of written arguments when extracting

python-rope · Dec 14, 2022 · 5fb5359 · 5fb5359
1 parent eeacfed
commit 5fb5359
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/rope/refactor/extract.py b/rope/refactor/extract.py
@@ -952,6 +952,8 @@ def _get_argnames(arguments):
         result.append(arguments.vararg.arg)
     if arguments.kwarg:
         result.append(arguments.kwarg.arg)
+    if arguments.kwonlyargs:
+        result.extend(node.arg for node in arguments.kwonlyargs)
     return result
 
 

diff --git a/ropetest/refactor/extracttest.py b/ropetest/refactor/extracttest.py
@@ -204,6 +204,24 @@ def new_func():
         """)
         self.assertEqual(expected, refactored)
 
+    def test_extract_function_with_kwonlyargs(self):
+        code = dedent("""\
+            def a_func(b, *, a_var):
+                another_var = 20
+                third_var = a_var + another_var
+        """)
+        start, end = self._convert_line_range_to_offset(code, 3, 3)
+        refactored = self.do_extract_method(code, start, end, "new_func")
+        expected = dedent("""\
+            def a_func(b, *, a_var):
+                another_var = 20
+                new_func(a_var, another_var)
+
+            def new_func(a_var, another_var):
+                third_var = a_var + another_var
+        """)
+        self.assertEqual(expected, refactored)
+
     def test_extract_function_with_multiple_return_values(self):
         code = dedent("""\
             def a_func():