Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow string type to be controlled from the public API #177

Merged
merged 7 commits into from Feb 14, 2022
Merged

Allow string type to be controlled from the public API #177

merged 7 commits into from Feb 14, 2022

Commits on Feb 10, 2022

  1. Allow string type to be controlled from the public API

    @abravalheri
    abravalheri committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    7ced061 View commit details
    Browse the repository at this point in the history

  2. Avoid double bookkeeping for String creation logic in 'items'

    @abravalheri
    abravalheri committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    3981f50 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG

    @abravalheri
    abravalheri committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    457aebd View commit details
    Browse the repository at this point in the history

  4. Fix linting errors

    @abravalheri
    abravalheri committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    e773d00 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2022

  1. Improve escaping for constructing strings via API

    @abravalheri
    abravalheri committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    cbf6b4e View commit details
    Browse the repository at this point in the history

  2. Ensure single line literal string doesn't contain "'"

    @abravalheri
    abravalheri committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    f92a3bc View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2022

  1. Fail if literal strings have invalid chars 

    Previously invalid chars were being escaped for the sake of not having
invalid strings.

It is preferable instead to explicitly fail.
    @abravalheri
    abravalheri committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    53219e9 View commit details
    Browse the repository at this point in the history