refactor installer extras handling, fix small bug, drop support for very old lock files #9345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radoering
force-pushed
the
refactor/installer-extras-handling
branch
from
923c08e
to
c0ade62
Compare
radoering
added a commit
to radoering/poetry
that referenced
this pull request
May 12, 2024
… and fix small bug (python-poetry#9345) * Operations are completely calculated in `Transaction.calculate_operations()` so that we do not have to remember extra uninstalls between two calculations. * Previously, extras that were not requested were not uninstalled when running `poetry install` (without extras) if there was no lockfile, now it does not matter if there was a lockfile or not. * In `installer._get_extra_packages()` we do not have to distinguish between locked extras and extras in the pyproject.toml because both must be consistent.
radoering
added a commit
to radoering/poetry
that referenced
this pull request
May 12, 2024
… lock file version 1.0 and Poetry 1.1) (python-poetry#9345)
radoering
force-pushed
the
refactor/installer-extras-handling
branch
from
c0ade62
to
298443b
Compare
radoering
force-pushed
the
refactor/installer-extras-handling
branch
from
298443b
to
440f62f
Compare
radoering
added a commit
to radoering/poetry
that referenced
this pull request
May 16, 2024
… and fix small bug (python-poetry#9345) * Operations are completely calculated in `Transaction.calculate_operations()` so that we do not have to remember extra uninstalls between two calculations. * Previously, extras that were not requested were not uninstalled when running `poetry install` (without extras) if there was no lockfile, now it does not matter if there was a lockfile or not. * In `installer._get_extra_packages()` we do not have to distinguish between locked extras and extras in the pyproject.toml because both must be consistent.
radoering
added a commit
to radoering/poetry
that referenced
this pull request
May 16, 2024
… lock file version 1.0 and Poetry 1.1) (python-poetry#9345)
radoering
added a commit
to radoering/poetry
that referenced
this pull request
May 19, 2024
… and fix small bug (python-poetry#9345) * Operations are completely calculated in `Transaction.calculate_operations()` so that we do not have to remember extra uninstalls between two calculations. * Previously, extras that were not requested were not uninstalled when running `poetry install` (without extras) if there was no lockfile, now it does not matter if there was a lockfile or not. * In `installer._get_extra_packages()` we do not have to distinguish between locked extras and extras in the pyproject.toml because both must be consistent.
radoering
added a commit
to radoering/poetry
that referenced
this pull request
May 19, 2024
… lock file version 1.0 and Poetry 1.1) (python-poetry#9345)
… and fix small bug (python-poetry#9345) * Operations are completely calculated in `Transaction.calculate_operations()` so that we do not have to remember extra uninstalls between two calculations. * Previously, extras that were not requested were not uninstalled when running `poetry install` (without extras) if there was no lockfile, now it does not matter if there was a lockfile or not. * In `installer._get_extra_packages()` we do not have to distinguish between locked extras and extras in the pyproject.toml because both must be consistent.
… lock file version 1.0 and Poetry 1.1) (python-poetry#9345)
radoering
force-pushed
the
refactor/installer-extras-handling
branch
from
440f62f
to
eaa25d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: python-poetry/poetry-plugin-export#279
should not be squashed
motivation:
Transaction.calculate_operations()and do not merge operations from several calculations ininstallerside effects:
poetry install(without extras) uninstalled them if there was a lock file but did not if there was none, now it always uninstalls them