Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail command install if cannot be installed #9333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eamanu
Copy link

@eamanu eamanu commented Apr 24, 2024

An error code is returned if the installation command fails. Also the style is changed from warning to error.

Tests was updated.

Pull Request Check List

Resolves: #8637

  • Added tests for changed code.
  • Updated documentation for changed code.

An error code is returned if the installation command fails. Also the
style is changed from warning to error.

Tests was updated.
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm just blocking this in case we will release a 1.9 before 2.0. (Currently, I do not think we will but who knows.) Considering the churn the warning caused, I think it would be too early to do this in a minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry install exit code 0 (success) even if readme file does not exist and fails to install the package
2 participants