New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix encoding warnings with PEP 597 enabled #8893
base: main
Are you sure you want to change the base?
Conversation
d4a1a67
to
5394e0b
Compare
d7ed6b0
to
84ad304
Compare
pre-commit.ci autofix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some warnings we should address.
d2e5309
to
6242db4
Compare
We are down to 1 warning:
I'm not sure what to do about that one since it is a mocked out version of check_output. |
Actually 1 more as well:
I'm not sure how to apply encodings to a check_call. |
The warning comes from calling the original method so I suppose at least one
Probably, the same as for the other methods. According to the docs it supports the same kwargs as |
d750b6a
to
4761b79
Compare
4761b79
to
7db4c0a
Compare
Hi @radoering, I rebased this on top of the main branch. Unfortunately mypy gives a |
Pull Request Check List
Resolves: #8892
This PR fixes Encoding Warnings with PEP 597 warnings enabled and enables the warnings in CI. There are also a few warnings with poetry-core and cleo, and I can submit PRs for those repos as well.