feat(locker): poetry lock works if an invalid/incompatible lock file exists
#6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radoering
added
impact/backport
|
Does this resolve #1196, or can it be extended to do so? |
radoering
force-pushed
the
lock-with-incompatible-lock-file
branch
from
d6132e0
to
46e2047
Compare
|
It does. I added a test. |
neersighted
added
area/error-handling
radoering
force-pushed
the
lock-with-incompatible-lock-file
branch
from
46e2047
to
a83b5e8
Compare
neersighted
approved these changes
Oct 10, 2022
neersighted
changed the title
poetry lock if an incompatible lock file existspoetry lock works if an invalid/incompatible lock file exists
poetry-bot bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
…e exists (#6753) After having created a lock file 2.0, running `poetry lock` with poetry 1.2.1 results in the following output: ``` The lock file is not compatible with the current version of Poetry. Upgrade Poetry to be able to read the lock file or, alternatively, regenerate the lock file with the `poetry lock` command. ``` Ironically, the error message proposes to run `poetry lock` which results in this error message. Further, it doesn't make sense that `poetry lock` fails because it creates a new lock file from scratch (in contrast to `poetry lock --no-update`). Running `poetry lock` is now also possible if there is a broken lock file. Resolves: #1196 (cherry picked from commit 7d414af)
neersighted
pushed a commit
that referenced
this pull request
Oct 10, 2022
…e exists (#6753) After having created a lock file 2.0, running `poetry lock` with poetry 1.2.1 results in the following output: ``` The lock file is not compatible with the current version of Poetry. Upgrade Poetry to be able to read the lock file or, alternatively, regenerate the lock file with the `poetry lock` command. ``` Ironically, the error message proposes to run `poetry lock` which results in this error message. Further, it doesn't make sense that `poetry lock` fails because it creates a new lock file from scratch (in contrast to `poetry lock --no-update`). Running `poetry lock` is now also possible if there is a broken lock file. Resolves: #1196 (cherry picked from commit 7d414af)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After having created a lock file 2.0, running
poetry lockwith poetry 1.2.1 results in the following output:Ironically, the error message proposes to run
poetry lockwhich results in this error message.Further, it doesn't make sense that
poetry lockfails because it creates a new lock file from scratch (in contrast topoetry lock --no-update).Update: Running
poetry lockis now also possible if there is a broken lock file.Resolves: #1196