adds fallback behavior for non-ms shells

[bmarroquin]

Pull Request Check List

Resolves: #6495

• Added tests for changed code.

Confirmed working on MS Powershell, Powershell 7, cmd and git bash

[neersighted]

A couple thoughts -- args should be hoisted instead of being part of an else branch.

However, I'm wondering about this whole approach. Doesn't pexpect work on Windows? Why not use the same code path we use on Unix OSes as much as possible, and keep the special-casing to Windows Powershell and cmd.exe?

[bmarroquin]

I'll give it a shot

[bmarroquin]

pexpect's windows support is missing the interact method. Without that, you can't run a sub shell or reuse any of the unix code path. I tried a few things but none of them worked.

[neersighted]

LGTM -- this class is heavily overloaded and needs to be refactored, but this was a regression in 1.2 and we shouldn't let the refactor block the fix.

[poetry-bot]

The backport to 1.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2 1.2
# Navigate to the new working tree
cd .worktrees/backport-1.2
# Create a new branch
git switch --create backport-6560-to-1.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3d422d72159418ca23105fb6ea38f86af62af23f
# Push it to GitHub
git push --set-upstream origin backport-6560-to-1.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2

Then, create a pull request where the base branch is 1.2 and the compare/head branch is backport-6560-to-1.2.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.