Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update poetry-core to 1.1.0b1 #5673

Merged
merged 6 commits into from May 23, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
94 changes: 47 additions & 47 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Expand Up @@ -44,7 +44,7 @@ generate-setup-file = false
[tool.poetry.dependencies]
python = "^3.7"

poetry-core = "^1.1.0a7"
poetry-core = "^1.1.0b1"
poetry-plugin-export = "^1.0.2"
cachecontrol = { version = "^0.12.9", extras = ["filecache"] }
cachy = "^0.3.0"
Expand Down
4 changes: 2 additions & 2 deletions src/poetry/console/commands/show.py
Expand Up @@ -393,7 +393,7 @@ def display_package_tree(
dependencies = package.requires
dependencies = sorted(
dependencies,
key=lambda x: x.name, # type: ignore[no-any-return]
key=lambda x: x.name,
)

tree_bar = "├"
Expand Down Expand Up @@ -437,7 +437,7 @@ def _display_tree(

dependencies = sorted(
dependencies,
key=lambda x: x.name, # type: ignore[no-any-return]
key=lambda x: x.name,
)
tree_bar = previous_tree_bar + " ├"
total = len(dependencies)
Expand Down
2 changes: 1 addition & 1 deletion src/poetry/factory.py
Expand Up @@ -41,7 +41,7 @@
logger = logging.getLogger(__name__)


class Factory(BaseFactory): # type: ignore[misc]
class Factory(BaseFactory):
"""
Factory class to create various elements needed by Poetry.
"""
Expand Down
2 changes: 1 addition & 1 deletion src/poetry/masonry/builders/editable.py
Expand Up @@ -40,7 +40,7 @@
"""


class EditableBuilder(Builder): # type: ignore[misc]
class EditableBuilder(Builder):
def __init__(self, poetry: Poetry, env: Env, io: IO) -> None:
super().__init__(poetry)

Expand Down
9 changes: 1 addition & 8 deletions src/poetry/mixology/version_solver.py
Expand Up @@ -19,7 +19,6 @@
from poetry.mixology.set_relation import SetRelation
from poetry.mixology.term import Term
from poetry.packages import DependencyPackage
from poetry.utils._compat import metadata


if TYPE_CHECKING:
Expand Down Expand Up @@ -47,13 +46,7 @@ def __init__(self, provider: Provider) -> None:
list[DependencyPackage],
] = {}

# TODO: re-enable cache when poetry-core upgrade is completed
self.search_for = functools.lru_cache(
maxsize=128
if metadata.version("poetry-core") # type: ignore[no-untyped-call]
!= "1.1.0a7"
else 0
)(self._search_for)
self.search_for = functools.lru_cache(maxsize=128)(self._search_for)
abn marked this conversation as resolved.
Show resolved Hide resolved

def _search_for(self, dependency: Dependency) -> list[DependencyPackage]:
key = (
Expand Down
4 changes: 2 additions & 2 deletions src/poetry/packages/locker.py
Expand Up @@ -309,7 +309,7 @@ def get_project_dependencies(
# Put higher versions first so that we prefer them.
for packages in packages_by_name.values():
packages.sort(
key=lambda package: package.version, # type: ignore[no-any-return]
key=lambda package: package.version,
reverse=True,
)

Expand Down Expand Up @@ -493,7 +493,7 @@ def _dump_package(self, package: Package) -> dict[str, Any]:
dependencies: dict[str, list[Any]] = {}
for dependency in sorted(
package.requires,
key=lambda d: d.name, # type: ignore[no-any-return]
key=lambda d: d.name,
):
if dependency.pretty_name not in dependencies:
dependencies[dependency.pretty_name] = []
Expand Down
2 changes: 1 addition & 1 deletion src/poetry/poetry.py
Expand Up @@ -20,7 +20,7 @@
from poetry.repositories.pool import Pool


class Poetry(BasePoetry): # type: ignore[misc]
class Poetry(BasePoetry):

VERSION = __version__

Expand Down
10 changes: 0 additions & 10 deletions src/poetry/puzzle/provider.py
Expand Up @@ -236,16 +236,6 @@ def search_for_vcs(self, dependency: VCSDependency) -> list[Package]:
Basically, we clone the repository in a temporary directory
and get the information we need by checking out the specified reference.
"""
# TODO: remove explicit subdirectory check once poetry-core is updated
# we ensure subdirectory match here as workaround until poetry-core is updated
# to >1.1.0a7
if (
dependency in self._deferred_cache
and self._deferred_cache[dependency].source_subdirectory
== dependency.source_subdirectory
):
return [self._deferred_cache[dependency]]

package = self.get_package_from_vcs(
dependency.vcs,
dependency.source,
Expand Down
2 changes: 1 addition & 1 deletion src/poetry/puzzle/solver.py
Expand Up @@ -141,7 +141,7 @@ def _solve(
)
for dependency_packages in locked.values():
dependency_packages.sort(
key=lambda p: p.package.version, # type: ignore[no-any-return]
key=lambda p: p.package.version,
reverse=True,
)

Expand Down
10 changes: 0 additions & 10 deletions tests/compat.py
Expand Up @@ -10,13 +10,3 @@
from typing import Protocol # nopycln: import
except ImportError:
from typing_extensions import Protocol # noqa: F401, TC002

from poetry.core.semver.helpers import parse_constraint
from poetry.core.semver.version import Version

from poetry.utils._compat import metadata


is_poetry_core_1_1_0a7_compat = not parse_constraint(">1.1.0a7").allows(
Version.parse(metadata.version("poetry-core"))
)