Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1] Ensure all hash types are checked #4529

Merged
merged 1 commit into from Sep 21, 2021
Merged

[1.1] Ensure all hash types are checked #4529

merged 1 commit into from Sep 21, 2021

Conversation

sdispater
Copy link
Member

Pull Request Check List

Resolves: #4523

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added kind/bug Something isn't working as expected area/installer Related to the dependency installer labels Sep 20, 2021
@sdispater sdispater force-pushed the 1.1-ensure-all-hash-types-are-checked branch from 14c8da8 to 2c1a86b Compare September 20, 2021 23:21
@MartinWallgren MartinWallgren mentioned this pull request Sep 21, 2021
Closed
3 tasks
@awilkins awilkins mentioned this pull request Sep 21, 2021
Closed
2 tasks
awilkins
awilkins reviewed Sep 21, 2021
View reviewed changes
Copy link

@awilkins awilkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, better mocking than my tests (you've definitely had more practice..). Reckon using the match for pytest.raises() would be neater.

tests/installation/test_executor.py Outdated Show resolved Hide resolved
poetry/installation/executor.py
raise RuntimeError(
"Invalid hash for {} using archive {}".format(package, archive.name)
"Invalid hashes ({}) for {} using archive {}. Expected one of {}.".format(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this better than my single hash message.

@sdispater sdispater force-pushed the 1.1-ensure-all-hash-types-are-checked branch 4 times, most recently from 89c9d9c to 43b7c61 Compare September 21, 2021 19:54
@sdispater sdispater force-pushed the 1.1-ensure-all-hash-types-are-checked branch from 43b7c61 to 5221df9 Compare September 21, 2021 19:56
@sdispater sdispater merged commit c195f2e into 1.1 Sep 21, 2021
@sdispater sdispater deleted the 1.1-ensure-all-hash-types-are-checked branch September 21, 2021 20:15
@sdispater sdispater mentioned this pull request Sep 21, 2021
Merged
@sdispater sdispater mentioned this pull request Nov 12, 2021
Closed
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
This allows for much-improved compatibility when interfacing with legacy
16c445c 
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
feat: Check all hash types when validating archives
ad027bb 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
feat: Check all hash types when validating archives
d4498a1 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
feat: Check all hash types when validating archives
9b8715c 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
feat: Check all hash types when validating archives
6b08351 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 13, 2021
@neersighted
feat: Check all hash types when validating archives
1623d99 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 15, 2021
@neersighted
feat: Check all hash types when validating archives
9d5dcf1 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 16, 2021
@neersighted
feat: Check all hash types when validating archives
50b4b43 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
neersighted added a commit that referenced this pull request Nov 19, 2021
@neersighted
feat: Check all hash types when validating archives
d342448 
This allows for much-improved compatibility when interfacing with legacy
PyPI-compatible repositories.

This is a successor PR to #4486, and closes #4578 and #4085.
This PR is also a forward-port of #4529.
@ITProKyle ITProKyle mentioned this pull request Mar 16, 2022
Closed
2 tasks
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@awilkins awilkins awilkins left review comments

Assignees
No one assigned
Labels
area/installer Related to the dependency installer kind/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sdispater @awilkins