Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for returncode when pip installing Poetry in install-poetry.py #4425

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Check for returncode when pip installing Poetry in install-poetry.py #4425

merged 1 commit into from
Aug 26, 2021

Conversation

mkniewallner
Copy link
Member

Pull Request Check List

Resolves: #4424

  • Added tests for changed code. Not applicable
  • Updated documentation for changed code. Not applicable

Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@finswimmer finswimmer merged commit 893fe1b into python-poetry:master Aug 26, 2021
@mkniewallner mkniewallner deleted the check-subprocess-returncode-install-poetry branch August 26, 2021 14:02
@mkniewallner
Copy link
Member Author

Sorry that this broke the installer, I should have been more careful.
Following up on this, I've made a PR to use install-poetry.py from the current branch rather than master, to ensure that changes in the script don't break the installer.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install-poetry.py doesn't exit with proper status code when installation fails
2 participants