cherry-pick PR #3406 for v1.1

[jstriebel]

This cherry-picks #3406 for v1.1 for a new patch-release. From the original PR:

Add PyPI registry correctly to pool depending on other sources (#3406)

In the event where we defined sources that were set as
secondary = True, we would end up with PyPI being after this source
when it should have acted as default in that case.

The main issue stems from the fact that it's not because you have
sources configured that PyPI should not be a default. Instead, PyPI
should be default if there are no sources with secondary = False and
not default if there are sources with secondary = True.

Pull Request Check List

Related to PR #3406, resolves #2339, resolves #3306, resolves #3238 for v1.1

[jstriebel]

It's not clear to me why the CI fails with

ValueError

Incorrectly nested style tag found.

Seems like the random error from #3010. The tests seem to work fine locally.

[jstriebel]

@sdispater Since you merged the original PR, could you have a look at this cherry-pick for v1.1? Thanks a lot!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[abn]

@jstriebel approving and merging this one. However, please note that we do not at present have a plan for another 1.1 release.

[caniko]

@jstriebel approving and merging this one. However, please note that we do not at present have a plan for another 1.1 release.

But it is a broken feature, shouldn't broken features be patched? Especially for those who won't upgrade to the next major/minor?

PS: Not pushing a patch for this bug is a minor mistake

[jstriebel]

@abn Thanks for merging!

However, please note that we do not at present have a plan for another 1.1 release.

Understandable, however it would be very useful, especially considering that 1.2 introduces bugs that might keep someone from upgrading to that version (in my case #4254). I'm therefore using the commit of this PR to install poetry atm.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.