Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the self update command and environment detection #4192

Merged
merged 2 commits into from Jun 23, 2021

Conversation

sdispater
Copy link
Member

@sdispater sdispater commented Jun 18, 2021

This PR ensures that the next bug fix release – which should be 1.1.7 – will be upgradable to the next feature release it it has been installed with the new installer.

It also ensures, similar to #4084, that the proper environment is selected instead of Poetry's own virtualenv.

Closes: #4147

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added Installer area/venv Related to virtualenv management labels Jun 18, 2021
@sdispater sdispater force-pushed the improve-self-update-and-env-detection branch 2 times, most recently from c168c1d to 06a28d0 Compare June 18, 2021 14:14
@sdispater sdispater force-pushed the improve-self-update-and-env-detection branch 10 times, most recently from f8d2d1b to 8fae35f Compare June 18, 2021 20:30
@sdispater sdispater force-pushed the improve-self-update-and-env-detection branch from 8fae35f to a42bdaf Compare June 18, 2021 20:34
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sdispater sdispater requested a review from a team June 18, 2021 21:24
@sdispater sdispater merged commit e077339 into 1.1 Jun 23, 2021
@sdispater sdispater deleted the improve-self-update-and-env-detection branch June 23, 2021 19:17
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/venv Related to virtualenv management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant