Add azure keyring support #3647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure Keyring works by storing the credentials under the full url of the repository in the keyring credentials.
bneijt
force-pushed
the
add-azure-keyring-support
branch
from
4334665
to
76b57bd
Compare
It was required because the config could also come from environment variables based on key translation.
bneijt
force-pushed
the
add-azure-keyring-support
branch
from
76b57bd
to
c5ddcb4
Compare
|
Hi @bneijt thanks very much for this PR - I'm having this problem and would love for this functionality to be merged. Do we have any idea on when this might be released ? |
|
Closing this pr. The caching required is quite ugly and we have been happily working around this issue by just doing No reason to keep this open. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #3344
I have added support for keyring lookup based on repository url via a
get_credentialscall, which is whatartifacts-keyringseems to do. Everyget_credentialscall is at Microsoft speed, so I had to also add a cache on the keyring values.