Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: execute parallel unsafe ops serially #3099

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

abn
Copy link
Member

@abn abn commented Oct 6, 2020

Resolves: #2658 #3086
Closes: #3095

@abn abn requested a review from a team October 6, 2020 09:38
@abn abn mentioned this pull request Oct 6, 2020
1 task
@abn abn added the kind/bug Something isn't working as expected label Oct 6, 2020
@abn abn added this to the 1.1 milestone Oct 6, 2020
Copy link
Contributor

@PetterS PetterS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this! 👍

I think that in order to test this, some refactoring of the code is needed.

poetry/installation/executor.py Show resolved Hide resolved
@abn
Copy link
Member Author

abn commented Oct 6, 2020

I think that in order to test this, some refactoring of the code is needed.

Race conditions are inherently hard to test. I would be happy with no regressions and manual verification for now.

Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@finswimmer finswimmer merged commit dc2a75d into python-poetry:1.1 Oct 6, 2020
@abn abn deleted the issue/3086 branch October 6, 2020 19:00
@abn abn linked an issue Oct 6, 2020 that may be closed by this pull request
3 tasks
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editable installs sometimes cannot be imported (poetry 1.1.0)
3 participants