Fix: allow whitespace in list of extras for a package #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
requested changes
Sep 27, 2020
tests/console/commands/test_init.py
Outdated
Comment on lines
561
to
563
| def test_add_package_with_extras_and_whitespace(app): | ||
| command = app.find("init") | ||
| result = command._parse_requirements(["databases[postgresql, sqlite]"]) |
There was a problem hiding this comment.
Suggested change
| def test_add_package_with_extras_and_whitespace(app): | |
| command = app.find("init") | |
| result = command._parse_requirements(["databases[postgresql, sqlite]"]) | |
| def test_add_package_with_extras_and_whitespace(tester): | |
| result = tester._parse_requirements(["databases[postgresql, sqlite]"]) |
There was a problem hiding this comment.
It look like it must be test._command._parse_requirements ...
| @@ -373,7 +373,7 @@ def _parse_requirements( | |||
| for requirement in requirements: | |||
| requirement = requirement.strip() | |||
| extras = [] | |||
| extras_m = re.search(r"\[([\w\d,-_]+)\]$", requirement) | |||
| extras_m = re.search(r"\[([\w\d,-_ ]+)\]$", requirement) | |||
There was a problem hiding this comment.
The range of \s is to wide. I don't think supporting e.g. tab characters here.
There was a problem hiding this comment.
Hmm, I guess for this case it is fine (ish). For PEP 508, whitespace typically refers to "non-line breaking whitespace". That is narrowier than \s and but wider than . I doubt anyone is going to type in foo[a, \t b] 😏
finswimmer
force-pushed
the
issue-2980-whitspace-extra-list
branch
from
56bc7f5
to
cddbcad
Compare
abn
approved these changes
Sep 28, 2020
abn
requested changes
Sep 28, 2020
abn
approved these changes
Sep 28, 2020
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows having whitespaces in the list of extras during
poetry add, e.g.poetry add databases[postgresql, sqlite].Pull Request Check List
Resolves: #2980