Skip to content

Commit

Permalink
remove poetry-core<=1.10a7 compatibility code
Browse files Browse the repository at this point in the history
  • Loading branch information
abn committed May 23, 2022
1 parent 81795fa commit 11cf8cc
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 54 deletions.
9 changes: 1 addition & 8 deletions src/poetry/mixology/version_solver.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
from poetry.mixology.set_relation import SetRelation
from poetry.mixology.term import Term
from poetry.packages import DependencyPackage
from poetry.utils._compat import metadata


if TYPE_CHECKING:
Expand Down Expand Up @@ -47,13 +46,7 @@ def __init__(self, provider: Provider) -> None:
list[DependencyPackage],
] = {}

# TODO: re-enable cache when poetry-core upgrade is completed
self.search_for = functools.lru_cache(
maxsize=128
if metadata.version("poetry-core") # type: ignore[no-untyped-call]
!= "1.1.0a7"
else 0
)(self._search_for)
self.search_for = functools.lru_cache(maxsize=128)(self._search_for)

def _search_for(self, dependency: Dependency) -> list[DependencyPackage]:
key = (
Expand Down
10 changes: 0 additions & 10 deletions src/poetry/puzzle/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,16 +236,6 @@ def search_for_vcs(self, dependency: VCSDependency) -> list[Package]:
Basically, we clone the repository in a temporary directory
and get the information we need by checking out the specified reference.
"""
# TODO: remove explicit subdirectory check once poetry-core is updated
# we ensure subdirectory match here as workaround until poetry-core is updated
# to >1.1.0a7
if (
dependency in self._deferred_cache
and self._deferred_cache[dependency].source_subdirectory
== dependency.source_subdirectory
):
return [self._deferred_cache[dependency]]

package = self.get_package_from_vcs(
dependency.vcs,
dependency.source,
Expand Down
10 changes: 0 additions & 10 deletions tests/compat.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,3 @@
from typing import Protocol # nopycln: import
except ImportError:
from typing_extensions import Protocol # noqa: F401, TC002

from poetry.core.semver.helpers import parse_constraint
from poetry.core.semver.version import Version

from poetry.utils._compat import metadata


is_poetry_core_1_1_0a7_compat = not parse_constraint(">1.1.0a7").allows(
Version.parse(metadata.version("poetry-core"))
)
7 changes: 0 additions & 7 deletions tests/console/commands/test_add.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
from poetry.core.semver.version import Version

from poetry.repositories.legacy_repository import LegacyRepository
from tests.compat import is_poetry_core_1_1_0a7_compat
from tests.helpers import get_dependency
from tests.helpers import get_package

Expand Down Expand Up @@ -993,9 +992,6 @@ def test_add_chooses_prerelease_if_only_prereleases_are_available(
• Installing foo (1.2.3b1)
"""
if is_poetry_core_1_1_0a7_compat:
expected = expected.replace("^1.2.3b1", "^1.2.3-beta.1")

assert expected in tester.io.fetch_output()


Expand Down Expand Up @@ -1926,9 +1922,6 @@ def test_add_chooses_prerelease_if_only_prereleases_are_available_old_installer(
- Installing foo (1.2.3b1)
"""
if is_poetry_core_1_1_0a7_compat:
expected = expected.replace("^1.2.3b1", "^1.2.3-beta.1")

assert expected in old_tester.io.fetch_output()


Expand Down
3 changes: 0 additions & 3 deletions tests/console/commands/test_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import pytest

from poetry.console.commands.version import VersionCommand
from tests.compat import is_poetry_core_1_1_0a7_compat


if TYPE_CHECKING:
Expand Down Expand Up @@ -53,8 +52,6 @@ def tester(command_tester_factory: CommandTesterFactory) -> CommandTester:
def test_increment_version(
version: str, rule: str, expected: str, command: VersionCommand
):
if is_poetry_core_1_1_0a7_compat:
expected = expected.replace("a", "-alpha.").replace("b", "-beta.")
assert command.increment_version(version, rule).text == expected


Expand Down
11 changes: 4 additions & 7 deletions tests/mixology/version_solver/test_dependency_cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

from poetry.factory import Factory
from poetry.mixology.version_solver import DependencyCache
from tests.compat import is_poetry_core_1_1_0a7_compat
from tests.mixology.helpers import add_to_repo


Expand Down Expand Up @@ -38,9 +37,8 @@ def test_solver_dependency_cache_respects_source_type(
packages_pypi = cache.search_for(dependency_pypi)
packages_git = cache.search_for(dependency_git)

if not is_poetry_core_1_1_0a7_compat:
assert cache.search_for.cache_info().hits == 2
assert cache.search_for.cache_info().currsize == 2
assert cache.search_for.cache_info().hits == 2
assert cache.search_for.cache_info().currsize == 2

assert len(packages_pypi) == len(packages_git) == 1
assert packages_pypi != packages_git
Expand Down Expand Up @@ -95,9 +93,8 @@ def test_solver_dependency_cache_respects_subdirectories(
packages_one = cache.search_for(dependency_one)
packages_one_copy = cache.search_for(dependency_one_copy)

if not is_poetry_core_1_1_0a7_compat:
assert cache.search_for.cache_info().hits == 2
assert cache.search_for.cache_info().currsize == 2
assert cache.search_for.cache_info().hits == 2
assert cache.search_for.cache_info().currsize == 2

assert len(packages_one) == len(packages_one_copy) == 1

Expand Down
6 changes: 1 addition & 5 deletions tests/puzzle/test_solver.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
from poetry.repositories.pool import Pool
from poetry.repositories.repository import Repository
from poetry.utils.env import MockEnv
from tests.compat import is_poetry_core_1_1_0a7_compat
from tests.helpers import get_dependency
from tests.helpers import get_package
from tests.repositories.test_legacy_repository import (
Expand Down Expand Up @@ -1384,10 +1383,7 @@ def test_solver_duplicate_dependencies_different_sources_types_are_preserved(

assert len(complete_package.all_requires) == 2

if is_poetry_core_1_1_0a7_compat:
pypi, git = complete_package.all_requires
else:
git, pypi = complete_package.all_requires
git, pypi = complete_package.all_requires

assert isinstance(pypi, Dependency)
assert pypi == dependency_pypi
Expand Down
5 changes: 1 addition & 4 deletions tests/utils/test_dependency_specification.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from deepdiff import DeepDiff

from poetry.utils.dependency_specification import parse_dependency_specification
from tests.compat import is_poetry_core_1_1_0a7_compat


if TYPE_CHECKING:
Expand Down Expand Up @@ -75,9 +74,7 @@
"name": "name",
"markers": 'python_version == "2.7"',
"url": "http://foo.com",
**(
{} if is_poetry_core_1_1_0a7_compat else {"extras": ["fred", "bar"]}
),
"extras": ["fred", "bar"],
},
),
(
Expand Down

0 comments on commit 11cf8cc

Please sign in to comment.