Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency: consider source_name in is_same_source_as #488

Closed
wants to merge 1 commit into from
Closed

dependency: consider source_name in is_same_source_as #488

wants to merge 1 commit into from

Conversation

radoering
Copy link
Member

As per python-poetry/poetry#6679 (comment)

  • Added tests for changed code.
  • Updated documentation for changed code.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@radoering radoering mentioned this pull request Oct 2, 2022
Merged
2 tasks
@radoering
Copy link
Member Author

Hmm, looking at the downstream tests perhaps not such a good idea after all. Have to take a closer look later.

@radoering
Copy link
Member Author

Discarding this for now because it breaks the heart of the dependency resolver. _compatible_dependency() compares dependencies with source_name with dependencies created from packages via to_dependency() which of course never have a source_name. Changing that would probably require a major refactoring.

@radoering radoering closed this Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@radoering