Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: make hash() consistent and incl features #438

Closed

Conversation

maksbotan
Copy link

This is a backport of 7e09102 from
master (PR #370).

  • Added tests for changed code.
  • Updated documentation for changed code.

As this is a backport to old branch that will never be merged to master, I took liberty to skip backporting tests. If you insist, I'll add them.

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@neersighted
Copy link
Member

Sorry for the late response here -- core is not accepting backports to the previous branch given the imminent release of Poetry 1.2. Our new release strategy will require new releases of Poetry for core bumps anyway (since we're now pinning versions), and we will likely keep core compatible with the stable version of Poetry as well as the dev branch so that we don't maintain multiple versions.

@maksbotan
Copy link
Author

Thanks @neersighted!

Can I draw your attention to my other two PRs, that actually implement new functionality?

python-poetry/poetry#6130
python-poetry/poetry#6131

@neersighted
Copy link
Member

I can try, but given we're in the final stages of 1.2's release that's where all energies are currently going. One of your PRs is likely to receive substantial feedback and/or a refactor from @radoering once his own related refactor lands.

@maksbotan
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants