tests: xfail test_pip_install_no_binary on Python 3.7 #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkniewallner
previously approved these changes
Jun 25, 2022
radoering
force-pushed
the
pip-install-no-binary-issue-py37
branch
from
e5ed65d
to
0981ab4
Compare
The test case fails due to the new release of setuptools_scm, which now depends on importlib-metadata for 'python_version < "3.8"'. Due to the fact that importlib-metadata itself depends on setuptools_scm, it's not possible anymore to "pip install --no-binary importlib-metadata" on Python 3.7.
radoering
force-pushed
the
pip-install-no-binary-issue-py37
branch
from
0981ab4
to
01bcc6b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mkniewallner
approved these changes
Jun 25, 2022
2 tasks
bostonrwalker
pushed a commit
to bostonrwalker/poetry-core
that referenced
this pull request
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case fails due to the new release of
setuptools_scm, which now depends onimportlib-metadataforpython_version < "3.8". Due to the fact that importlib-metadata itself depends on setuptools_scm, it's not possible anymore topip install --no-binary importlib-metadataon Python 3.7.Related to python/importlib_metadata#392