Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Python 2 jobs #126

Merged
merged 1 commit into from Nov 16, 2019
Merged

Removed Python 2 jobs #126

merged 1 commit into from Nov 16, 2019

Conversation

radarhere
Copy link
Member

@hugovk
Copy link
Member

hugovk commented Oct 1, 2019

If we merge this now, what would we need to do if we need to do a 6.2.x point release for Python 2.7?

Should we tag this master with 6.2.0 to match the main repo?

@radarhere
Copy link
Member Author

I might have made a comment about point releases being rare, but then python-pillow/Pillow#4110 suggested one, so never mind.

On the other hand, if PR python-pillow/Pillow#4109 is merged, then the 2.7 wheels CI jobs will start failing.

@radarhere radarhere force-pushed the python branch 2 times, most recently from b5620ea to 9e56047 Compare October 22, 2019 18:50
@radarhere
Copy link
Member Author

Actually, pillow-wheels 2.7 latest has already started failing - https://travis-ci.org/python-pillow/pillow-wheels/builds/602789711

@hugovk
Copy link
Member

hugovk commented Oct 26, 2019

"Latest" is off the master branch, which no longer supports Python 2.7, right?

If we needed to do a 6.2.2 security release for 2.7, that would be from the 6.2.x branch and we don't need to worry about the latest (which happened with 6.2.1).

So we could exclude the 2.7/latest jobs here.

Or merge this, and if we do need to do a 6.2.2 (hopefully won't happen), we can always reinstate these 2.7 builds.

What do you think?

@radarhere
Copy link
Member Author

We're now halfway towards the next release, and the odds of 6.2.2 gradually decrease as time goes on - we haven't made a patch release after the first month in the last three years.

I think it might be more valuable to merge, to allow better visibility for true failures. If 6.2.2 occurs, then we can work to involve 2.7 builds for that.

@radarhere radarhere merged commit a414cd7 into python-pillow:master Nov 16, 2019
@radarhere radarhere deleted the python branch November 16, 2019 02:21
@hugovk
Copy link
Member

hugovk commented Nov 16, 2019

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants