Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to GitHub Actions #107

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Move CI to GitHub Actions #107

merged 3 commits into from
Nov 17, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 16, 2020

Travis CI has a new pricing model which places limits on open source.

Many projects are moving to GitHub Actions instead, and we're moving the python-pillow repos over: python-pillow/Pillow#5028.

This PR removes the Travis CI testing and does the same on GitHub Actions.

Once difference: GHA doesn't have allow_failures like Travis does, and the 3.10-dev (which is the closest to nightly on Travis) is failing because Wheel doesn't yet support 3.10: pypa/wheel#354. So that's commented out for now.

Example build:

@nulano
Copy link

nulano commented Nov 16, 2020

Once difference: GHA doesn't have allow_failures like Travis does, and the 3.10-dev (which is the closest to nightly on Travis) is failing because Wheel doesn't yet support 3.10: pypa/wheel#354. So that's commented out for now.

There is https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error, but it's not entirely clear to me what it does from the documentation and I haven't tried it myself.

@hugovk
Copy link
Member Author

hugovk commented Nov 16, 2020

Currently, using ‘continue-on-error:’ in a step flags the step with a green check and allows the job to continue. The only way to see if the step failed is to look at the step’s log.

https://github.community/t/continue-on-error-allow-failure-ui-indication/16773

Also: actions/runner#2347

@homm
Copy link
Member

homm commented Nov 17, 2020

Do we need to enable Actions somehow for the repo first to see this config in action? )

@hugovk
Copy link
Member Author

hugovk commented Nov 17, 2020

It should be enabled on merge.

Or you could try pushing my fork's branch to a branch in this repo, that might do it.

You can see a test run https://github.com/hugovk/pillow-perf/actions/runs/365836504

If you prefer, we could keep .travis.yml in this PR, merge, and remove it in a followup PR.

@homm homm merged commit 8552064 into python-pillow:master Nov 17, 2020
@hugovk hugovk deleted the rm-travis branch November 17, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants