Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ubuntu 24.04 #205

Merged
merged 5 commits into from Apr 28, 2024
Merged

Added Ubuntu 24.04 #205

merged 5 commits into from Apr 28, 2024

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Apr 27, 2024

Ubuntu 24.04 has been released - https://releases.ubuntu.com/noble/

Transitioning to the new Ubuntu meant updating to Python 3.12, and adding libxcb-shape0 for PySide6, but also, an error started appearing from addgroup pillow sudo
https://github.com/radarhere/docker-images/actions/runs/8857703276/job/24325472410#step:6:2293

fatal: addgroup with two arguments is an unspecified operation.

Removing the command then led to a permission error during install - it turns out that our use of 1000 as the pillow user id

sudo chown -R 1000 $(pwd)

doesn't work on Ubuntu 24.04. It has moved from 1000 to 1001. To be consistent, I've updated all images to use 1001.

@hugovk
Copy link
Member

hugovk commented Apr 27, 2024

Ignoring the failures for a moment, the build time for ubuntu-22.04-jammy-arm64v8 -> ubuntu-24.04-noble-arm64v8 is now very long: 26m -> 2h 3m.

Let's stick with 22.04 for at least this one.


For the manylinux ones:

docker: Error response from daemon: pull access denied for pythonpillow/ubuntu-24.04-noble-amd64, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

Let's check those after merging so that image has been published.

@radarhere
Copy link
Member Author

Ok. I've restored 22.04 arm64v8, and created python-pillow/Pillow#8024 to increase the timeout to allow valgrind to pass.

@hugovk
Copy link
Member

hugovk commented Apr 27, 2024

Valgrind is now the slowest one and has increased from 1h9m to 1h30m with 24.04. Let's stay on 22.04 a bit longer there too.

@radarhere
Copy link
Member Author

Ok, done.

@hugovk
Copy link
Member

hugovk commented Apr 28, 2024

Thanks!

This maybe wasn't very clear:

For the manylinux ones:

docker: Error response from daemon: pull access denied for pythonpillow/ubuntu-24.04-noble-amd64, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

Let's check those after merging so that image has been published.

I meant: let's revert these, merge, and do those in a followup. So we can make sure they pass before merging.

@hugovk
Copy link
Member

hugovk commented Apr 28, 2024

Thank you very much!

@hugovk hugovk merged commit d8cc080 into python-pillow:main Apr 28, 2024
22 checks passed
@radarhere radarhere deleted the ubuntu24_04 branch April 28, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants