Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate getdata and putdata tests #8017

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Consolidate getdata and putdata tests #8017

wants to merge 9 commits into from
+153 −165

Commits on May 15, 2024

  1. move getdata/putdata tests to same file

    @Yay295
    Yay295 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c4979ae View commit details
    Browse the repository at this point in the history

  2. parametrize test_getdata_roundtrip()

    @Yay295
    Yay295 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0c0c14a View commit details
    Browse the repository at this point in the history

  3. parametrize test_putdata_long_integers() 

    This test had some duplicate checks because originally in Python 2 the numbers in those lines had a "L" suffix, which is no longer used in Python 3.
    @Yay295
    Yay295 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c73511b View commit details
    Browse the repository at this point in the history

  4. remove old comment 

    The original bug this was referring to seems to have been lost, but it looks to have been something to do with Python 2/3 compatibility and big numbers.
See commit c8ce29c and python-pillow#7991.
    @Yay295
    Yay295 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    da024cb View commit details
    Browse the repository at this point in the history

  5. Rename variable "pixel" to "expected" 

    Co-authored-by: Ondrej Baranovič <ondreko.tiba@gmail.com>
    @Yay295 @nulano
    Yay295 and nulano committed May 15, 2024
    Configuration menu
    Copy the full SHA
    62c1908 View commit details
    Browse the repository at this point in the history

  6. rename test_image_getdata_putdata.py to test_image_data.py

    @Yay295
    Yay295 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a6ef0ab View commit details
    Browse the repository at this point in the history

  7. parametrize test_putdata_array()

    @Yay295
    Yay295 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e534ed8 View commit details
    Browse the repository at this point in the history

  8. merge test_putdata_mode_I() and test_putdata_mode_F() as test_putdata… 

    …_scale_and_offset()
    @Yay295
    Yay295 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    b426421 View commit details
    Browse the repository at this point in the history

  9. remove test_putdata_mode_BGR(), superseded by test_getdata_putdata()

    @Yay295
    Yay295 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    ba83ec4 View commit details
    Browse the repository at this point in the history