Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only install pyroma 4.0 in Cygwin #6759

Closed
wants to merge 1 commit into from

Conversation

radarhere
Copy link
Member

@hugovk
Copy link
Member

hugovk commented Nov 25, 2022

I'd rather we figure out the root cause rather than pinning (indefinitely?) pyroma, alternatively we could skip pyroma for Cygwin altogether.

I wonder if this is another setuptools thing? pyroma now requires setuptools>=61.0.0:

regebro/pyroma@4.0...4.1

From the logs:

Collecting setuptools>=61.0.0
  Using cached setuptools-65.6.3-py3-none-any.whl (1.2 MB)
...
  Attempting uninstall: setuptools
    Found existing installation: setuptools 59.5.0
    Uninstalling setuptools-59.5.0:
      Successfully uninstalled setuptools-59.5.0
...
Successfully installed build-0.9.0 certifi-2022.9.24 charset-normalizer-2.1.1 docutils-0.19 idna-3.4 pep517-0.13.0 pygments-2.13.0 pyroma-4.1 requests-2.28.1 setuptools-65.6.3 trove-classifiers-2022.10.19 urllib3-1.26.13

Here's a passing build with pyroma 4.1 and pinning to old setuptools 59.5.0, but segmentation fault for 3.8 and 3.9 when running tests (3.7 passed):

Here's a failing build with pyroma 4.0 and bumping to latest setuptools:

Yup, looks like setuptools fun again...

@radarhere
Copy link
Member Author

After looking at #6216 (comment), I've created #6760

@radarhere radarhere closed this Nov 25, 2022
@radarhere radarhere deleted the cygwin branch November 25, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants